Fix/linewidth - #170
Closed
MMenninger wants to merge 2 commits into
Closed
Conversation
Changed to linewidth: theme_cmap.R — geom_hline/geom_vline (the origin lines), all six element_line() calls (gridlines, axis lines, ticks), the base line element, and the element_rect() border in theme_cmap_base(). default_aes.R — the GeomLine default only. geom_recessions.R / geom_pandemics.R — the GeomRecessions/GeomPandemics default_aes (size = 0.5 → linewidth = 0.5) and their draw code (lwd = coords$size → coords$linewidth), kept internally consistent. Left as size (correctly): all element_text() font sizes, the text-geom defaults (3.88, fsize/.pt), and the point-geom sizes (GeomPointLast, and the coords$size in the point-drawing code). DESCRIPTION: bumped ggplot2 to >= 3.4.0 in Depends — linewidth was introduced there, so this is now the real floor. Each replacement ran with an exact occurrence-count assertion, so nothing over-matched, and all four R files are brace-balanced and untruncated. Fix typo: theme_cmap_base() read $fgiont instead of $font The `text` element in theme_cmap_base() referenced cmapplot_globals$fgiont$regular$face, which resolved to NULL and dropped the base theme's default font face. Corrected to $font.
Collaborator
|
@MMenninger Closing for now due to incompatibility with checks, will rebase to current master and apply "size --> linewidth" updates manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.